Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value arr size input #121

Merged
merged 17 commits into from
Feb 22, 2024
Merged

value arr size input #121

merged 17 commits into from
Feb 22, 2024

Conversation

volodymyr-basiuk
Copy link
Contributor

@volodymyr-basiuk volodymyr-basiuk commented Feb 15, 2024 •
edited
Loading

  • added valueArraySize input
  • disable SMTVerifier for NOOP operator
  • added new IN template (InWithDynamicArraySize) which works with valueArraySize input
  • removed testvectors from repo

@volodymyr-basiuk volodymyr-basiuk changed the title WIP: Feature/value arr size input WIP: value arr size input Feb 15, 2024
@volodymyr-basiuk volodymyr-basiuk changed the base branch from master to develop February 15, 2024 17:19
@volodymyr-basiuk volodymyr-basiuk changed the title WIP: value arr size input value arr size input Feb 21, 2024
@volodymyr-basiuk volodymyr-basiuk marked this pull request as ready for review February 21, 2024 13:39
OBrezhniev
OBrezhniev requested changes Feb 22, 2024
View reviewed changes
circuits/lib/query/comparators.circom Outdated Show resolved Hide resolved
circuits/lib/utils/arraySizeValidator.circom Outdated Show resolved Hide resolved
circuits/lib/utils/arraySizeValidator.circom Show resolved Hide resolved
testvectorgen/credentials/onchain/v3/v3_test.go Show resolved Hide resolved
testvectorgen/credentials/v3/v3_test.go Show resolved Hide resolved
testvectorgen/utils/utils.go Outdated Show resolved Hide resolved
@volodymyr-basiuk volodymyr-basiuk merged commit 00154aa into develop Feb 22, 2024
2 checks passed
@volodymyr-basiuk volodymyr-basiuk deleted the feature/value-arr-size-input branch February 22, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OBrezhniev OBrezhniev OBrezhniev approved these changes

@vmidyllic vmidyllic Awaiting requested review from vmidyllic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volodymyr-basiuk @OBrezhniev