Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pid 1054 #170

Merged
merged 47 commits into from
Sep 19, 2023
Merged

Feature/pid 1054 #170

merged 47 commits into from
Sep 19, 2023

Conversation

volodymyr-basiuk
Copy link
Contributor

No description provided.

@volodymyr-basiuk volodymyr-basiuk marked this pull request as draft August 8, 2023 11:25
@coveralls
Copy link

coveralls commented Aug 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6220756698

  • 88 of 93 (94.62%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.7%) to 87.057%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/validators/CredentialAtomicQueryValidator.sol 37 42 88.1%
Totals Coverage Status
Change from base Build 5870932696: 3.7%
Covered Lines: 513
Relevant Lines: 553
💛 - Coveralls

vmidyllic
vmidyllic reviewed Aug 9, 2023
View reviewed changes
contracts/interfaces/ICircuitValidator.sol Outdated Show resolved Hide resolved
contracts/interfaces/IZKPVerifier.sol Outdated Show resolved Hide resolved
contracts/interfaces/IZKPVerifier.sol Outdated Show resolved Hide resolved
contracts/validators/CredentialAtomicQueryValidator.sol Show resolved Hide resolved
contracts/interfaces/ICircuitValidator.sol Outdated Show resolved Hide resolved
contracts/interfaces/IZKPVerifier.sol Outdated Show resolved Hide resolved
contracts/validators/CredentialAtomicQueryValidator.sol Outdated Show resolved Hide resolved
contracts/validators/CredentialAtomicQueryValidator.sol Show resolved Hide resolved
contracts/verifiers/ZKPVerifier.sol Outdated Show resolved Hide resolved
contracts/verifiers/ZKPVerifier.sol Outdated Show resolved Hide resolved
@volodymyr-basiuk volodymyr-basiuk marked this pull request as ready for review August 10, 2023 08:08
vmidyllic
vmidyllic previously approved these changes Sep 15, 2023
View reviewed changes
@vmidyllic vmidyllic merged commit 107ec52 into master Sep 19, 2023
5 checks passed
@vmidyllic vmidyllic deleted the feature/pid-1054 branch September 19, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmidyllic vmidyllic vmidyllic approved these changes

@AndriianChestnykh AndriianChestnykh AndriianChestnykh approved these changes

@OBrezhniev OBrezhniev OBrezhniev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@volodymyr-basiuk @coveralls @OBrezhniev @AndriianChestnykh @vmidyllic