[docs][README] Update badges #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why this change was necessary** Dependency installation checks were added in #387. These Actions should be pointed to by the README badges until we have workflows actually testing the application build (#268 and others). **What this change does** Updates badges to point to the dependency installation workflows. **Any side-effects?** None **Additional context/notes/links** - List of open issues mentioning testing: https://github.com/idoneam/Canary/issues?q=is%3Aissue+is%3Aopen+test
le-potate
reviewed
Jan 9, 2021
Resolves #388 (review)
Resolves #388 (comment) and #388 (comment)
le-potate
previously approved these changes
Jan 9, 2021
jidicula
added a commit
that referenced
this pull request
Jan 9, 2021
A badge title is defined by the corresponding workflow's `name` attribute. Resolves #388 (review)
|
I think you also need to update the urls now that the names have changed |
A badge title is defined by the corresponding workflow's `name` attribute. Resolves #388 (review)
Good catch. I've updated the urls and the titles again. The dev badge will only update upon merge (since it points to |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change was necessary
Dependency installation checks were added in #387. These Actions
should be pointed to by the README badges until we have workflows
actually testing the application build (#268 and others).
What this change does
Updates badges to point to the dependency installation workflows.
Any side-effects?
None
Additional context/notes/links