Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke VID #210 #221

Merged
merged 20 commits into from
Sep 21, 2022
Merged

Revoke VID #210 #221

merged 20 commits into from
Sep 21, 2022

Conversation

danicaerediano
Copy link
Collaborator

Closes #210

Currently works with MOCK SERVER

@danicaerediano danicaerediano force-pushed the feature/210-revoke-vid branch from 00953a9 to 8741a8d Compare August 22, 2022 11:27
@danicaerediano danicaerediano linked an issue Sep 13, 2022 that may be closed by this pull request
Revoke VID #210
Open
@danicaerediano danicaerediano marked this pull request as ready for review September 13, 2022 10:00
pmigueld
pmigueld requested changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@pmigueld pmigueld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working in Android 10.

Revoke does not work properly in iOS because of nested modals/overlays (you cannot nest them in iOS). Please refactor to use screens and the router.

@pmigueld pmigueld merged commit 89897c5 into develop Sep 21, 2022
@pmigueld pmigueld deleted the feature/210-revoke-vid branch September 21, 2022 09:48
This was referenced Oct 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmigueld pmigueld pmigueld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revoke VID
3 participants
@danicaerediano @pmigueld @danicaMat