-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(tools): add fta #699
Conversation
Warning Rate Limit Exceeded@Idrinth has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 43 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent changes enhance the CI process across multiple projects by integrating the File Type Analyzer (FTA) tool. This addition aims to improve code quality by evaluating complexity and maintainability to ensure adherence to set standards before merging into the master branch. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
name: history-microservice FTA | ||
on: | ||
push: | ||
branches: | ||
- master | ||
paths: | ||
- 'history-microservice/**.ts' | ||
- 'history-microservice/**.tsx' | ||
- 'history-microservice/**.js' | ||
- 'history-microservice/**.cjs' | ||
- 'history-microservice/**.json' | ||
- 'history-microservice/**.svelte' | ||
- '.github/workflows/history-microservice.fta.yml' | ||
pull_request: | ||
branches: | ||
- master | ||
paths: | ||
- 'history-microservice/**.ts' | ||
- 'history-microservice/**.tsx' | ||
- 'history-microservice/**.js' | ||
- 'history-microservice/**.cjs' | ||
- 'history-microservice/**.json' | ||
- 'history-microservice/**.svelte' | ||
- '.github/workflows/history-microservice.fta.yml' | ||
env: | ||
PREVIOUS_NODE_VERSION: ${{ vars.PREVIOUS_NODE_VERSION || 'lts/*' }} | ||
CURRENT_NODE_VERSION: ${{ vars.CURRENT_NODE_VERSION || 'latest' }} | ||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Use Node.js ${{ env.CURRENT_NODE_VERSION }} | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ env.CURRENT_NODE_VERSION }} | ||
cache: 'npm' | ||
cache-dependency-path: | | ||
framework/package-lock.json | ||
documentation-website/package-lock.json | ||
history-microservice/package-lock.json | ||
history-microservice/package-lock.json | ||
cli/package-lock.json | ||
package-lock.json | ||
- run: npm ci | ||
- run: cd history-microservice && npm ci && npm run language | ||
- run: npm run fta -- history-microservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider specifying a more restrictive set of branches for triggers to avoid unnecessary runs on all branches.
push:
branches:
- - master
+ - main
paths:
This change ensures that the workflow only runs on the main branch, which is a common practice for protecting key branches in a project. If your project uses a different branch as its primary branch, adjust accordingly.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
name: history-microservice FTA | |
on: | |
push: | |
branches: | |
- master | |
paths: | |
- 'history-microservice/**.ts' | |
- 'history-microservice/**.tsx' | |
- 'history-microservice/**.js' | |
- 'history-microservice/**.cjs' | |
- 'history-microservice/**.json' | |
- 'history-microservice/**.svelte' | |
- '.github/workflows/history-microservice.fta.yml' | |
pull_request: | |
branches: | |
- master | |
paths: | |
- 'history-microservice/**.ts' | |
- 'history-microservice/**.tsx' | |
- 'history-microservice/**.js' | |
- 'history-microservice/**.cjs' | |
- 'history-microservice/**.json' | |
- 'history-microservice/**.svelte' | |
- '.github/workflows/history-microservice.fta.yml' | |
env: | |
PREVIOUS_NODE_VERSION: ${{ vars.PREVIOUS_NODE_VERSION || 'lts/*' }} | |
CURRENT_NODE_VERSION: ${{ vars.CURRENT_NODE_VERSION || 'latest' }} | |
jobs: | |
lint: | |
runs-on: ubuntu-latest | |
steps: | |
- uses: actions/checkout@v4 | |
- name: Use Node.js ${{ env.CURRENT_NODE_VERSION }} | |
uses: actions/setup-node@v4 | |
with: | |
node-version: ${{ env.CURRENT_NODE_VERSION }} | |
cache: 'npm' | |
cache-dependency-path: | | |
framework/package-lock.json | |
documentation-website/package-lock.json | |
history-microservice/package-lock.json | |
history-microservice/package-lock.json | |
cli/package-lock.json | |
package-lock.json | |
- run: npm ci | |
- run: cd history-microservice && npm ci && npm run language | |
- run: npm run fta -- history-microservice | |
name: history-microservice FTA | |
on: | |
push: | |
branches: | |
- main | |
paths: | |
- 'history-microservice/**.ts' | |
- 'history-microservice/**.tsx' | |
- 'history-microservice/**.js' | |
- 'history-microservice/**.cjs' | |
- 'history-microservice/**.json' | |
- 'history-microservice/**.svelte' | |
- '.github/workflows/history-microservice.fta.yml' | |
pull_request: | |
branches: | |
- master | |
paths: | |
- 'history-microservice/**.ts' | |
- 'history-microservice/**.tsx' | |
- 'history-microservice/**.js' | |
- 'history-microservice/**.cjs' | |
- 'history-microservice/**.json' | |
- 'history-microservice/**.svelte' | |
- '.github/workflows/history-microservice.fta.yml' | |
env: | |
PREVIOUS_NODE_VERSION: ${{ vars.PREVIOUS_NODE_VERSION || 'lts/*' }} | |
CURRENT_NODE_VERSION: ${{ vars.CURRENT_NODE_VERSION || 'latest' }} | |
jobs: | |
lint: | |
runs-on: ubuntu-latest | |
steps: | |
- uses: actions/checkout@v4 | |
- name: Use Node.js ${{ env.CURRENT_NODE_VERSION }} | |
uses: actions/setup-node@v4 | |
with: | |
node-version: ${{ env.CURRENT_NODE_VERSION }} | |
cache: 'npm' | |
cache-dependency-path: | | |
framework/package-lock.json | |
documentation-website/package-lock.json | |
history-microservice/package-lock.json | |
history-microservice/package-lock.json | |
cli/package-lock.json | |
package-lock.json | |
- run: npm ci | |
- run: cd history-microservice && npm ci && npm run language | |
- run: npm run fta -- history-microservice |
framework/package-lock.json | ||
documentation-website/package-lock.json | ||
history-microservice/package-lock.json | ||
history-microservice/package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the duplicate entry for history-microservice/package-lock.json
in the cache-dependency-path.
history-microservice/package-lock.json
- history-microservice/package-lock.json
Having duplicate entries does not provide any benefit and could potentially lead to confusion or errors in cache handling.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
history-microservice/package-lock.json |
Quality Gate passedIssues Measures |
The Pull Request is ready
Overview
Tools
Summary by CodeRabbit
fta
script inpackage.json
for running the File Type Analyzer (FTA) tool.fta.js
) for assessing file types and displaying formatted results based on predefined score thresholds.