Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: openpilot Plotjuggler VideoViewer #23

Open
wants to merge 1 commit into
base: example_openpilot
Choose a base branch
from

Conversation

iejMac
Copy link
Owner

@iejMac iejMac commented Dec 4, 2022

@iejMac
Copy link
Owner Author

iejMac commented Dec 4, 2022

openai can you summarize this PR?

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

This pull request adds functionality to the example_openpilot application that allows it to use Plotjuggler VideoViewer to visualize videos related to the openpilot log. It adds two new functions to framereader.py: ffprobe, which is used to gather information about the video, and ffmpeg_concatenate, which is used to concatenate multiple videos for analysis. Also, a new variable - video_path - is added to juggle.py, which allows it to pass the video path information to the ffmpeg_concatenate function. Finally, it adds logic to juggle.py to check for videos related to the log, and if there are any, it will concatenate them before passing them to the viewer.

Possible improvements to this pull request include adding further error handling and validation steps to ensure that the video path is valid, and to check whether the video can be played by the VideoViewer. Additionally, it might be useful to add a feature that allows the user to select which videos they would like to view.

@iejMac iejMac added the example label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant