IshaanG/week1 #3
Open
+224
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karngyan
reviewed
Dec 21, 2019
karngyan
reviewed
Dec 21, 2019
| @@ -0,0 +1,45 @@ | |||
| import requests | |||
There was a problem hiding this comment.
You should consider adding Module/Class/Method and docstring as well.
It's easier for coders to understand what your module/class/method does.
Also how about sorting the import orders as well.
You can refer this: https://www.python.org/dev/peps/pep-0008/#imports
karngyan
reviewed
Dec 21, 2019
karngyan
reviewed
Dec 21, 2019
karngyan
reviewed
Dec 21, 2019
| data_all.append(data) | ||
| with open('data.json', 'w', encoding='utf-8') as f: | ||
| json.dump(data_all, f, ensure_ascii=False, indent=4) | ||
|
|
There was a problem hiding this comment.
This method doesn't manipulate class properties or states. It might be a good idea to use @staticmethod decorator.
What do you say?
karngyan
reviewed
Dec 21, 2019
karngyan
reviewed
Dec 21, 2019
karngyan
reviewed
Dec 21, 2019
Week-1/IshaanG/trackprice.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| import spec | |||
There was a problem hiding this comment.
Add documentation and correct the import order here as well.
karngyan
reviewed
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.