Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change receipts 394 to a TBD with IANA Considerations #332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SteveLasker
Copy link
Collaborator

Fixes #326

Comment on lines +1031 to +1040
## COSE Receipts Header Parameter

{{-COMETRE}} is requesting IANA to add the following entries to the [COSE Header Algorithm Parameters Registry](https://www.iana.org/assignments/cose/cose.xhtml).

- Name: receipts
- Label: TBD_0 (requested assignment 394)
- Value type: array (of bstr)
- Value registry: https://www.iana.org/assignments/cose/cose.xhtml#header-parameters
- Description: Priority ordered list of CBOR encoded Receipts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the authors of that spec are requesting it for that draft, why are we doubling that request here? Do we not need to specify we want to replace the values later once that is formalized with an explanation between this section and the previous header?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little repetitive. We must change 394, as it creates confusion for implementors. This section was copy/pasted over for completeness. Either way, when TBD_0 is assigned, this will get cleaned up, so I felt it was helpful to provide a pointer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aj-stein, do still feel strongly? I'd like to merge to get to #341

@SteveLasker SteveLasker requested a review from aj-stein January 22, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make reference to Receipt Label 394 a TBD
2 participants