create rust cli tooling #123
Conversation
cli-rust/src/subcmd/add_liquidity.rs
Outdated
|
|
||
| if let Err(e) = client.get_account(&mint_lp_tokens_to) { | ||
| if !mint_lp_tokens_to.eq(&from_ata) { | ||
| panic!( |
There was a problem hiding this comment.
is this how i throw error?
There was a problem hiding this comment.
Yeah so as in stakedex-cli I decided that since it's just a simple cli program, panicking is fine and probably what we want to do when we encounter an error so that the user can just get feedback on what went wrong and the program exits.
Also you probably learnt this from the book alrdy but just in case: panicking is also what happens when .unwrap() fails
Note that in larger/long-running applications (like the stakedex-api server), you probably never want to panic since that means your entire application crashes
There was a problem hiding this comment.
I think for learning purposes, you can look into defining explicit error type
cli-rust/src/subcmd/add_liquidity.rs
Outdated
| let msg = Message::new(&instructions, Some(&payer.pubkey())); | ||
| let blockhash = client.get_latest_blockhash().unwrap(); | ||
| let mut tx = Transaction::new(&signers.iter().collect(), msg, blockhash); | ||
| let sig = client.send_and_confirm_transaction(&tx).unwrap(); |
There was a problem hiding this comment.
is this how i create, sign and send tx?
There was a problem hiding this comment.
yep, when in doubt refer to stakedex-cli: https://github.com/igneous-labs/stakedex-cli/blob/master/src/subcmd/fund_sol_bridge.rs , https://github.com/igneous-labs/stakedex-cli/blob/master/src/tx_utils.rs
We might want to add a --dry-run flag for this too but that can come later
cli-rust/src/subcmd/unstakes.rs
Outdated
| lamports_to_sol(total_fees_lamports) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
this file has a lot of errors, not sure how to fix them
cli-rust/src/subcmd/unstakes.rs
Outdated
| if err.is_some() { | ||
| return; | ||
| } | ||
| // if inner_instructions.is_some() { |
There was a problem hiding this comment.
how can i check if this is falsey
cli-rust/src/subcmd/unstakes.rs
Outdated
| .collect(); | ||
|
|
||
| for (sig_idx, c) in confirmed_txs.iter().enumerate() { | ||
| // if c.is_none() { |
There was a problem hiding this comment.
how can i check if this is falsey
There was a problem hiding this comment.
I think we can also just add a #[derive(Debug)] on top of ProtocolFee Fee and Pool in programs/unstake so that they impl debug and then change all the println statements in fetch_protocol_fee and view_pool to stuff like println!("Fee:\n{:#?}", fee) instead of referencing all the individual fields
Also theres probably some more cargo clippy warnings to resolve
finish view_pool cmd
add set_fee_authority
Cli/set fee
Cli/unstake interface serde feature
add set_flash_loan_fee cmd
add remove_liquidity
Cli/init protocol fee
add create_pool cmd
Cli/fetch protocol fee
closes #122