Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2889: i18n properties: don't convert from UTF-8 to Latin1 #2559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OF-2889: i18n properties: don't convert from UTF-8 to Latin1 #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions i18n/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,4 @@
<artifactId>i18n</artifactId>
<name>Internationalization files for Openfire</name>
<description>These files are shared among the starter and xmppserver modules</description>
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
</resource>
</resources>

<plugins>
<plugin>
<!--
Java has trouble reading translations from UTF-8 files. To work around that,
this plugin ensures that Java-compatible encoding is used.
See https://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>native2ascii-maven-plugin</artifactId>
<version>2.0.1</version>
<executions>
<execution>
<id>utf8-to-latin1</id>
<goals>
<goal>inplace</goal>
</goals>
<configuration>
<dir>${project.build.outputDirectory}</dir>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
25 changes: 1 addition & 24 deletions plugins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,7 @@
</plugin>
<plugin>
<!--
Java has trouble reading translations from UTF-8 files. To work around that,
this plugin copies the i18n files from source to the build directory, to be
modified later by the native2ascii-maven-plugin.
This plugin copies the i18n files from source to the build directory.
-->
<artifactId>maven-resources-plugin</artifactId>
<version>3.1.0</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can eliminate the step to copy resources but not sure if this doesn't broke anything

Expand All @@ -208,27 +206,6 @@
</execution>
</executions>
</plugin>
<plugin>
<!--
Java has trouble reading translations from UTF-8 files. To work around that,
this plugin ensures that Java-compatible encoding is used.
See https://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle
-->
<groupId>org.codehaus.mojo</groupId>
<artifactId>native2ascii-maven-plugin</artifactId>
<version>2.0.1</version>
<executions>
<execution>
<id>utf8-to-latin1</id>
<goals>
<goal>inplace</goal>
</goals>
<configuration>
<dir>${project.build.directory}/i18n/</dir>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Expand Down
Loading