fix: Fix XmlStringBuilder caching.

XmlStringBuilder.append(Element) calls into the generic append(CharSequence) method which breaks the caching.
igniterealtime · Oct 25, 2023 · d0ec48e · d0ec48e
1 parent 2e79a6b
commit d0ec48e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java b/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java
@@ -597,7 +597,13 @@ public XmlStringBuilder condAttribute(boolean condition, String name, String val
     @Override
     public XmlStringBuilder append(CharSequence csq) {
         assert csq != null;
-        sb.append(csq);
+        if (csq instanceof XmlStringBuilder) {
+            sb.append(((XmlStringBuilder) csq).sb);
+        } else if (csq instanceof LazyStringBuilder) {
+            sb.append((LazyStringBuilder) csq);
+        } else {
+            sb.append(csq);
+        }
         return this;
     }