Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatMarkersManager improved - part 2 #272

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

miguelhincapie
Copy link
Contributor

  • Filters modified to allow xep-0333 be used in MUC.
  • Validation when trying to obtain Chat instance.
  • Created a method to notify the recipients about new state.

* Filters modified to allow xep-0333 be used in MUC.
* Validation when trying to obtain Chat instance.
* Created a method to notify the recipients about new state.
Copy link
Member

@vanitasvitae vanitasvitae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your contributions 👍
I found some things that can be improved :)

@IgniteRealtime-Bot
Copy link

This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there:

https://discourse.igniterealtime.org/t/chat-markers-support-in-smack-xep-0333/73202/16

@Flowdalic Flowdalic self-assigned this Feb 5, 2019
Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the big merge happened, I have some time to work on the pending PRs, starting with yours. :)

Please find my comments inline.

* @throws InterruptedException if the connection is interrupted.
* @throws IllegalStateException if one of the params don't match the rules.
*/
public void markMessage(Message message, ChatMarkersState chatMarkersState, String messageId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that the user gives as a message with a markable extension to such a method. Then you could remove the ChatMarkersState and String (messageId) parameters, which would make the method much more user friendly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the user would need to deal with message.addExtension(new ChatMarkersElements.ReceivedExtension(messageId)); by himself, in other words he would doing some of the job that this class has to do.

What I want is class that can be used almost out of the box but of course knowing how the XEP works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants