WIP : Add support for GS2 SASL (RFC 5801) #360
Conversation
Yes Thanks |
smack-core/src/main/java/org/jivesoftware/smack/sasl/gssApi/GssApiMechanism.java
Outdated
Show resolved
Hide resolved
smack-core/src/main/java/org/jivesoftware/smack/sasl/gssApi/GssApiMechanism.java
Outdated
Show resolved
Hide resolved
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/igniterealtime/Smack/wiki/Guidelines-for-Smack-Developers-and-Contributors This message was auto-generated by https://gitcop.com |
| @@ -10,6 +10,7 @@ dependencies { | |||
| compile "org.jxmpp:jxmpp-core:$jxmppVersion" | |||
| compile "org.jxmpp:jxmpp-jid:$jxmppVersion" | |||
| compile "org.minidns:minidns-core:$miniDnsVersion" | |||
| compile "org.bouncycastle:bcprov-jdk15on:$bouncyCastleVersion" | |||
| gssManager = GSSManager.getInstance(); | ||
|
|
||
| try { | ||
| userName = gssManager.createName(connection.getUser().asEntityBareJid().asEntityBareJidString(),GSSName.NT_USER_NAME); |
There was a problem hiding this comment.
Nit: Missing spaces after comma.
checkstyle will probably let you know of this as well :P
| import java.io.InputStream; | ||
| import java.io.OutputStream; | ||
|
|
||
| public class GssContext implements GSSContext { |
There was a problem hiding this comment.
Having classes with names that only differ in capitalization may cause issues on non-unix systems like windows.
While windows is not supported, I'd recommend using a different name for the interface anyway just to not complicate the situation further.
There was a problem hiding this comment.
I see that the GSSContext class is coming out of a library, so maybe this isn't an issue after all?
| @@ -193,4 +197,4 @@ private static int paddingToLen(int padlen) { | |||
| } | |||
| } | |||
|
|
|||
| } | |||
| } | |||
| return GS2_PREFIX + base32Encoding; | ||
| } | ||
|
|
||
| private static String getbinary55Bits(String sha1_hash) { |
There was a problem hiding this comment.
Nit: better use camelCase for the method name
|
@adiaholic: Any news? |
The code currently is shabby, and will be reformatted.
I am making attempts on this issue unit test by unit test.
This PR progress constitutes :
This is an attempt at solving SMACK-717.