Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to make is_deleted field redefined and optional? #88

Closed
lisij86 opened this issue May 16, 2024 · 3 comments
Closed

Is it possible to make is_deleted field redefined and optional? #88

lisij86 opened this issue May 16, 2024 · 3 comments
Labels
enhancement New feature or request FastCRUD Methods Related to FastCRUD methods good first issue Good for newcomers

Comments

@lisij86
Copy link

lisij86 commented May 16, 2024

fastcrud/fastcrud/crud/fast_crud.py

Line 1697 in adf9ab0

.values(is_deleted=True, deleted_at=datetime.now(timezone.utc))

It would be convenient to make this field redefined to self.is_deleted_column and optional, because in some cases, one deleted_at_column field is enough to understand that the record has been deleted.
@lisij86 lisij86 changed the title Is it possible to make the field redefined and optional? Is it possible to make is_deleted field redefined and optional? May 16, 2024
@igorbenav
Copy link
Owner

This is possible

@igorbenav igorbenav added enhancement New feature or request good first issue Good for newcomers FastCRUD Methods Related to FastCRUD methods labels Jun 4, 2024
@igorbenav igorbenav mentioned this issue Aug 11, 2024
Closed
5 tasks
This was referenced Aug 13, 2024
Merged
Merged
@gsegatti
Copy link

I think we can close this based on #152 being merged?

@igorbenav
Copy link
Owner

Yeah, @gsegatti, I forgot about the closing keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request FastCRUD Methods Related to FastCRUD methods good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lisij86 @igorbenav @gsegatti