Make is_deleted Field Optional and Configurable in Soft Delete Logic
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `is_deleted` field optional and configurable in soft delete logic
Update fast_crud.py
|
Hey, @gal-dahan, can you fix the typing? |
Done ✅ |
|
Hi, I did it. Can you approve the PR?
בתאריך יום ב׳, 19 באוג׳ 2024 ב-2:53 מאת Igor Benav <
***@***.***>:
… Hey, @gal-dahan <https://github.com/gal-dahan>, can you fix the typing?
—
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP7TFBPHFAMEGIZ2PBU4NTTZSEXY5AVCNFSM6AAAAABMO4FMWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGQ2DANJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
igorbenav
approved these changes
Sep 6, 2024
Nice! |
This was referenced Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for FastCRUD
Description
This pull request introduces changes to make the is_deleted field optional and configurable in the soft delete logic of the FastCRUD class. This issues #88
Changes
Added logic to conditionally update the is_deleted column based on its presence in the configuration.
Updated the soft delete process to only set the is_deleted field if it is explicitly configured.
Tests
No new tests have been added yet
Checklist