Improve update method when item is not found #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianaklulo
force-pushed
the
enhancement/improve-update-when-not-found
branch
from
1df782a to
2bd5062
Compare
igorbenav
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Hey, @julianaklulo, great first PR🚀!
Thank you so much. Just one thing, can you please make it like this so we raise a warning for now (explaining that stuff will change) and then easily change this behavior in the next version?
julianaklulo
force-pushed
the
enhancement/improve-update-when-not-found
branch
from
6784a56 to
0cb5cb8
Compare
igorbenav
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Great contribution, @julianaklulo, welcome to FastCRUD contributors🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for FastCRUD
Description
Improve the behaviour of CRUD
updatemethod when the filtered item for update is not found.It was requested (and closes #137) to keep consistency with the CRUD
deletemethod.Changes
Raise exception
NoResultFoundwhen the filters for the object to update don't match any items.Tests
Updated:
sqlalchemy/crud/test_update.py:test_update_non_existent_record,test_update_invalid_filterssqlalchemy/crud/test_get_multi_by_cursor.py:test_test_get_multi_by_cursor_pagination_integritysqlmodel/crud/test_update.py:test_update_non_existent_record,test_update_invalid_filterssqlmodel/crud/test_get_multi_by_cursor.py:test_test_get_multi_by_cursor_pagination_integrityChecklist
Additional Notes
Include any additional information that you think is important for reviewers to know.