Noise shards together #345
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmbc
force-pushed
the
noise_shards_together
branch
from
c9e8a3d to
78c9f82
Compare
zmbc
force-pushed
the
noise_shards_together
branch
from
78c9f82 to
9513813
Compare
albrja
approved these changes
Oct 27, 2023
|
It is surprising that this makes noising slower. I guess it's just the size of the data once we concat all of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noise shards together
Description
The thinking here was that noising the shards all at once could simplify things, especially having to use heuristics to warn the user about unsatisfiable noise requests. However, in its current state this PR makes pseudopeople markedly slower. I am not sure why.
Testing
pytest --runslow)