Add linting to makefile #564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricktnast
requested review from
albrja,
collijk,
hussain-jafari,
rmudambi and
stevebachmeier
as code owners
rmudambi
reviewed
Dec 27, 2024
| @@ -77,6 +77,11 @@ format: setup.py pyproject.toml $(MAKE_SOURCES) # Run the code formatter and imp | |||
| isort $(LOCATIONS) | |||
| @echo "Ignore, Created by Makefile, `date`" > $@ | |||
|
|
|||
| lint: .flake8 .bandit $(MAKE_SOURCES) # Run the code linter and package security vulnerability checker | |||
There was a problem hiding this comment.
I think we talked about how we aren't using this tool?
|
won't do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linting to makefile
Description
Changes and notes
copied 'make lint' flake8 check from another repo (i think synth_pop)
Testing