Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "macos-13" runner label in "pytest" workflow #527

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Apr 23, 2024

@glatterf42 noticed today that CI jobs were failing:

  • For ixmp, message-ix, and message-ix-models.
  • For macOS only.

…and traced this to a change in the standard GitHub Actions runners.

This PR switches to macos-13 for these workflows.
NB I also had to change the branch protection rule for main to replace macos-latest-py3.12 as a required check with macos-13-py3.12.

  • Another possible mitigation, but more work, is to get the workaround discussed in IXMP on Apple Silicon (ARM architecture) #473 to function on the GHA amd64 runners.
  • In the future, macos-12 and eventually macos-13 labels will be deprecated and removed by GitHub. The above issue gives 2024-Q3 to deprecate and 2024-Q4 to remove macos-12, and has macos-13 still in general availability ("GA") through 2024-Q4.
  • We would need to either do the above or get the test suite running with ixmp4 for macOS, i.e. via Implement IXMP4Backend #516 and other work.

How to review

Note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (707353e) to head (1945ad0).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #527   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files         44      44           
  Lines       4804    4804           
=====================================
  Hits        4754    4754           
  Misses        50      50           

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests seem to be passing again. Thanks :)

@khaeru
Copy link
Member Author

khaeru commented Apr 23, 2024

I left a longer discussion above so we can just cite this issue in PRs for the other two repos. Could you please open those?

At some point, we should open a PR (and maybe re-open #473) that updates the install instructions document a minimal work-around, maybe in the “Troubleshooting” section, for users who encounter that issue. As you noted, there are likely to be more in the future. We could then link to that work-around from the other install docs on the stack.

@khaeru khaeru merged commit ac0bba1 into main Apr 23, 2024
21 checks passed
@khaeru khaeru deleted the ci/macos-13 branch April 23, 2024 08:24
@glatterf42
Copy link
Member

glatterf42 commented Apr 23, 2024

The message_ix "Install from conda-forge" workflow succeeds with macos-latest, so maybe this offers hints at a solution, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants