-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change input file formats and input paths in chilled
#29
Draft
measrainsey
wants to merge
40
commits into
main
Choose a base branch
from
chilled/input-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
measrainsey
force-pushed
the
chilled/input-files
branch
from
October 15, 2024 11:33
fc43519
to
9ec16d5
Compare
Copied over from /DLE - Analysis/Climate impacts and space conditioning/Data/input_data/arch_input_v17_dle_coolssp2050_reg.xlsx
Copied over from /DLE - Analysis/Climate impacts and space conditioning/Data/input_data/arch_input_v17_dle_coolssp2050_reg.xlsx
Currently data is stored in a folder that has a version number on it. It would be better to remove this so the files being read won't be dependent on this numbering system but instead should only depend on version name.
Update postprocessing file in CHILLED
Move user-based path setting out of Config object
measrainsey
changed the title
Change input archetype files from .xlsx to .csv
Change input file formats in Oct 31, 2024
chilled
This allows for the logs to be output in the terminal, which is helpful when running CHILLED on UniCC.
measrainsey
changed the title
Change input file formats in
Change input file formats and input paths in Oct 31, 2024
chilled
chilled
measrainsey
force-pushed
the
chilled/input-files
branch
from
December 18, 2024 14:37
d21989f
to
8d340e9
Compare
Nd is cooling-specific only and therefore is not read in or calculating when heating is switched on. Thus the code crashes here since the Nd files are missing if only heating is run.
measrainsey
force-pushed
the
chilled/input-files
branch
from
December 19, 2024 15:48
966c43f
to
92e6b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the input archetype files within CHILLED (
message_ix_buildings.data.chilled
) from Excel form to CSV files.Having them be CSVs will allow for easier tracking, and in the end nothing about them requires the use of Excel spreadsheets.
Included in this PR:
Config