-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate MESSAGEix-Materials updates #188
Conversation
Thanks @macflo8, this will be very useful :) |
This could also be accomplished by giving a |
At #189 (comment) I mentioned the commit message format in our code style. For this longer branch, it seems there are a lot more commits affected, so maybe the suggestion of manual changes during Second, note that #186 has been merged recently. While it is not necessary to constantly rebase this branch and the one for #189, both should be based on the latest |
Thanks for the comments @glatterf42 ad 1) Since we still rely on ad 2) that is a good catch. Yes, I think they can be deleted. I see that they are also still present on the original migrate branch. I will discuss it with @GamzeUnlu95. |
Thanks for the explanation, @macflo8 :) |
in addition growth_activity_lo for bof_steel is set.
Change data paths from message-ix-models to message_data for some files
* Migrate already-present functions to common location * Exclude that location from ruff :( * Adapt imports in material and legacy reporting
Move doc.rst in material folder, rename to index.rst and pull updated contents from branch "migrate-materials-tidy"
Clean up Materials migration branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I think we can merge it with the understanding that #194 (in particular writing tests) should be addressed soon afterwards.
This should be celebrated and mentioned in the next weekly MESSAGE meeting (at least :) |
Yes definitely! 🥳 Many thanks to both of you @glatterf42 @khaeru for the help and guidance with the migration and everything else for this PR! |
Very well done, and congrats! |
This PR migrates the remaining updates of MESSAGEix-Materials to message-ix-models and is planned to complement #130 and potentially supersede it eventually.
Major model changes
Demand projections for all materials commodities now processed all in one module
Base year demand data is moved from code to separate yaml files (example)
Implementation of SSP differentiated dimensions:
Refactored base year harmonization of industry energy consumption using latest IEA data
Steps run so far
The code has been migrated from the private repository with the procedure described in the documentation.
Further steps
How to review
developer (someone like the reviewer) will be able to understand what the code
does in the future.
PR checklist
- [ ] Continuous integration checks all ✅Not possible due to missing tests- Add or expand tests; coverage checks both ✅See Clean up Materials migration branch #189 (comment); will be handled via Test and improve.model.material
#194