Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc/material/index to doc/index #196

Merged
merged 1 commit into from
May 27, 2024
Merged

Add doc/material/index to doc/index #196

merged 1 commit into from
May 27, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 27, 2024

This was missed in #189, and as a result one can't see the new module in the "Model variants" section of the left navbar or the ToC on the index page.

How to review

Look at the RTD docs build for this PR and confirm that .model.material appears in both places: https://iiasa-energy-program-message-ix--196.com.readthedocs.build/projects/models/en/196/

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew. Silent clean-up of PR that's already mentioned.

@khaeru khaeru added doc Improvements or additions to documentation material MESSAGEix-Materials variant labels May 27, 2024
@khaeru khaeru self-assigned this May 27, 2024
@khaeru khaeru requested a review from macflo8 May 27, 2024 09:44
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.1%. Comparing base (e76bbd3) to head (8cb79c6).
Report is 1664 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #196     +/-   ##
=======================================
- Coverage   52.2%   52.1%   -0.1%     
=======================================
  Files        141     141             
  Lines      11342   11335      -7     
=======================================
- Hits        5921    5914      -7     
  Misses      5421    5421             

see 4 files with indirect coverage changes

Copy link
Contributor

@macflo8 macflo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see .model.material in both places now. looks good to me

@khaeru khaeru merged commit c6285cf into main May 27, 2024
26 checks passed
@khaeru khaeru deleted the doc/materials branch May 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation material MESSAGEix-Materials variant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants