Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SSP argument options #233

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Extend SSP argument options #233

merged 2 commits into from
Sep 26, 2024

Conversation

OFR-IIASA
Copy link
Contributor

@OFR-IIASA OFR-IIASA commented Sep 26, 2024

The mix-models --ssp= CLI option is used in the SSP 2024/ScenarioMIP workflows, but originally had only SSP1 through SSP3 as accepted values. This adds SSP4, SSP5, and LED.

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@OFR-IIASA OFR-IIASA added the enh New features or functionality label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.5%. Comparing base (d90c11c) to head (f6de7bb).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #233     +/-   ##
=======================================
- Coverage   66.5%   65.5%   -1.0%     
=======================================
  Files        204     204             
  Lines      15822   15822             
=======================================
- Hits       10526   10378    -148     
- Misses      5296    5444    +148     
Files with missing lines Coverage Δ
message_ix_models/util/click.py 93.1% <ø> (ø)

... and 7 files with indirect coverage changes

@khaeru
Copy link
Member

khaeru commented Sep 26, 2024

Thanks @OFR-IIASA. FYI @glatterf42, I will:

  • Rebase.
  • Complete the PR description and checklist.
  • Ask for your review.

@macflo8, please let us know if you had made this change in a different way.

@khaeru khaeru added the p:SSP-2024 2024 SSP updates and ScenarioMIP label Sep 26, 2024
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if the functions using --ssp also know how to handle the new values :)

@khaeru khaeru merged commit 7632a17 into main Sep 26, 2024
26 checks passed
@khaeru khaeru deleted the ssp_dev branch September 26, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality p:SSP-2024 2024 SSP updates and ScenarioMIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants