Use placeholders for cached portals #1042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple avoidance of errors when trying to access cached portals
Moved in-progress modifications to branch
Grammar correction (!) modified: code/hooks.js Realigned names for readability new file: plugins/chat-hooks.js Begin to add generic chat-hooks. WIP!
Fix LinkedList Add text to chathook type hash Fix order for adding event to list
Add test code; Reorder handlePublicData to generate newEvent on the initial pass.
chat-hooks-test triggers on resonator deploy/destroy as well as portal link to draw circles to a layer. Added commented out code to chat-hooks for potential upgrade to using sync.
| @@ -67,9 +69,13 @@ window.plugin.portalslist.fields = [ | |||
| title: "Level", | |||
| value: function(portal) { return portal.options.data.level; }, | |||
| format: function(cell, portal, value) { | |||
| var level_text = "L?"; | |||
There was a problem hiding this comment.
Perhaps a ternary might be neater here?
var level_text = "L" + (value ? value : "?")There was a problem hiding this comment.
How obvious :D
Will change that when I get a chance.
Minor changes to chat-hooks-test and chat-hooks
…cles for factions
player-frequency: Add checkboxes for filtering users
…gress-intel-total-conversion into player-frequenting
Add refresh on selection change
|
It seems like this PR contains too many unrelated changes.. |
|
Hmm. Something odd's going on here; probably a misunderstanding on my part... I'll try and sort it all out and re-create the PR. |
|
You created this PR from your |
|
Yes, I can see that, now! I had expected the pull to be taken at a particular revision. |
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things - firstly, use the accessor functions to get at the portal information (cached or otherwise), secondly, use default (placeholder) text for elements that haven't yet been retrieved for cached portals.
Further mods I'd like to make are to refresh the portal data as it becomes available (particularly when you select a link for an "UNCACHED" portal name, it would be nice to have it re-populate the portal list with the retrieved data)