-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Bookmarks". New "Portals Exporter". #397
Conversation
JS_Interface callback
…let it work with JS calls
…'s identical in all plugins, so the mobile app can remove/modify it without issues. also makes it easy to change if required
… load on the niantic servers, especially in the case of multiple repeated scroll/zoom actions in the same area
- there is no reason why we shouldn't do it this way
…latively friendly on the servers to boost the map detail level for given zoom levels
increase map tile cache to 2 minutes, so the increased refresh for chat does not impact map data tile requests
…de into a plugin log data vs map zoom to console
…onal level yes, this does increase the requests to the niantic servers, but with the new cache code it's not that bad
- times are now in seconds rather than minutes, like all other IITC time settings - ignore mousemove events for no/small movements - more likely to go idle when it should
…le time wasn't reached
…et the guessed levels handy to clear out bad guesses due to ada refactor/jarvis virus use
…e' after hiding+showing the window
…resh timeout as if the map had just moved this way, if you switch back to IITC, then quickly move/zoom (as often is done), unnecessary network requests are avoided because of the change, there's no need for chat to have it's own resume hook - it already hooks into the refresh code and this is now triggered quickly
could do with some further code cleanups/improvements
some experimental bucket selections - commented out fixed north/south lat variables being backwards. only affected the debug tiles, which coped with it without problems
Issue #375. Also type check in weakness highlighter
…some requests are likely to timeout, by putting uncached tile ids at the start of the request, cached (but stale) at the end
…of date/up to date' message, and tool tip with tile counts for #394
Conflicts: code/map_data.js
Update "Bookmarks": - fixed some bugs; - optimized code to get portals/maps data - Added panel for export, import and reset the bookmarks; - Added the 'star' (to add a portal in bookmarks) in the new mobile status bar; New "Portals Exporter". Generate a kml structure to import into Google Maps or Google Drive: - Export portals; - Customize caption (address, image, coordinates); - Filters by owner faction and levels; - Support to Bookmarks plugin (export one or more folders from the Portals Bookmarks);
The portals-exporter plugin does not compile for me.. |
@leCradle maybe I was wrong to edit the code (applying the @@). I'll try the errors. Thanks. |
@ZasoGD yep. the files in the zip compille and work. I think we can merge this when the @@ error is fixed. |
Although it is a requested feature, I have a policy to NOT allow exporting of portal information outside of the browser environment. As it stands IITC is tolerated, if not officially accepted, by Niantic/Google. Allowing bulk data exporting would violate more of their terms and conditions, and is likely to bring a take-down request on the project. |
Well...then a new pull request including only the bookmark plugin improvements will be the way to go.. |
@jonatkins I'm sorry, I had thought the plugin as a multi map-links (link in portaldetails). I understand and respect your (iitc) policy. I'll create a new pull request when i correct "bookmarks". |
Update "Bookmarks":
status bar;
New "Portals Exporter". Generate a kml structure to import into Google Maps or Google Drive:
Portals Bookmarks);