Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing preprocessing and postprocessing (per sample) #152

Open
3 of 5 tasks
m-novikov opened this issue Feb 25, 2021 · 1 comment
Open
3 of 5 tasks

Implement missing preprocessing and postprocessing (per sample) #152

m-novikov opened this issue Feb 25, 2021 · 1 comment

Comments

@m-novikov
Copy link
Collaborator

m-novikov commented Feb 25, 2021

Main issue about implementing pre/post-processing in tiktorch.
For now, we decided to go only with per_sample implementation per_dataset would be added after
Descriptions in configuration spec

Finished implementation should contain:

  1. Snapshot tests
  2. Should correctly handle axes keyword argument if present in the spec
  3. Should have a docstring
  4. Should use xarray/numpy for implementation and not framework-specific tools
  5. Should correctly propagate axis tags
@k-dominik
Copy link
Collaborator

Should scale_range be added here, too? or can it already be found some place else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants