Add "scale_linear" preprocessing operation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-dominik
reviewed
Mar 22, 2021
| @@ -12,6 +12,10 @@ def make_ensure_dtype_preprocessing(dtype): | |||
| return Preprocessing(name="__tiktorch_ensure_dtype", kwargs={"dtype": dtype}) | |||
|
|
|||
|
|
|||
| def scale_linear(tensor: xr.DataArray, *, gain, offset) -> xr.DataArray: | |||
| return gain * tensor + offset | |||
There was a problem hiding this comment.
what happens to overflows here? (what is supposed to happen?) Or maybe rephrase, is it okay to change dtype here?
There was a problem hiding this comment.
Good catch, but I think we should address this question at the spec level. That is, any decision will be easy to implement, but it needs to be consistent with the other spec implementors.
is it okay to change dtype here?
I think we have to do it anyway: gain and offset might be floats.
There was a problem hiding this comment.
The current implementation casts input to a model dtype before doing any preprocessing, which is probably float32 in ~99% cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #152