Refactor TANE-based algorithms #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliya-b
force-pushed
the
pfdtane-generalize
branch
from
83dee44 to
9b3495c
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
2 times, most recently
from
c70c5bc to
0a0ef54
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
from
0a0ef54 to
d6b8714
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
4 times, most recently
from
74d5672 to
ca769bb
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
7 times, most recently
from
98159e0 to
554d08c
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
3 times, most recently
from
13016d9 to
84cf071
Compare
iliya-b
force-pushed
the
pfdtane-generalize
branch
6 times, most recently
from
0b202ac to
5ea3e11
Compare
`clang-format-diff` errors out in case of an error, not executing the following commands in the script
The old version does not contain the typing header.
Note that calling algorithms is not thread-safe. However, this allows algorithms to call Python code from multiple threads.
iliya-b
force-pushed
the
pfdtane-generalize
branch
from
5ea3e11 to
57905a7
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -26,7 +26,7 @@ INITIALIZE_EASYLOGGINGPP | |||
|
|
|||
| namespace python_bindings { | |||
|
|
|||
| PYBIND11_MODULE(desbordante, module) { | |||
| PYBIND11_MODULE(desbordante, module, pybind11::mod_gil_not_used()) { | |||
There was a problem hiding this comment.
warning: invalid case style for variable 'PYBIND11_MODULE' [readability-identifier-naming]
Suggested change
| PYBIND11_MODULE(desbordante, module, pybind11::mod_gil_not_used()) { | |
| pybin_d11_module(desbordante, module, pybind11::mod_gil_not_used()) { |
iliya-b
force-pushed
the
pfdtane-generalize
branch
4 times, most recently
from
646bc0f to
400f9e8
Compare
chernishev
force-pushed
the
pfdtane-generalize
branch
from
400f9e8 to
250f0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize Tane and PFDTane, add additional tests.
In order to check if the refactoring caused any performance loss, following experiments were performed.
The discovery task was run as
cli.py --task=afd --algo=tane --error=0.01 --table=...with new and original versions of TANE implementation. Following heavy datasets were utilized: EpicMeds.csv, adult.csv, EpicVitals.csv.Following list demonstrates measured running time of the old and new algorithms, correspondingly (confidence intervals of 95%, with 8-11 iteration):