-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pfdtane nongeneralized #6
base: main
Are you sure you want to change the base?
Conversation
Add TANE-based algorithm PFDTane for mining probabilistic functional dependencies using per-value error measure. Add tests.
e03af21
to
63b992f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
4633ecb
to
adf6486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
#include "table_config.h" | ||
|
||
namespace tests { | ||
namespace onam = config::names; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: expected namespace name [clang-diagnostic-error]
namespace onam = config::names;
^
|
||
PFDTaneParams(std::string result, double const error = 0., char const* dataset = "TestFD.csv", | ||
char const separator = ',', bool const has_header = true) | ||
: params({{onam::kCsvPath, test_data_dir / dataset}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'onam' [clang-diagnostic-error]
: params({{onam::kCsvPath, test_data_dir / dataset},
^
PFDTaneParams(std::string result, double const error = 0., char const* dataset = "TestFD.csv", | ||
char const separator = ',', bool const has_header = true) | ||
: params({{onam::kCsvPath, test_data_dir / dataset}, | ||
{onam::kSeparator, separator}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'onam' [clang-diagnostic-error]
{onam::kSeparator, separator},
^
char const separator = ',', bool const has_header = true) | ||
: params({{onam::kCsvPath, test_data_dir / dataset}, | ||
{onam::kSeparator, separator}, | ||
{onam::kHasHeader, has_header}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'onam' [clang-diagnostic-error]
{onam::kHasHeader, has_header},
^
: params({{onam::kCsvPath, test_data_dir / dataset}, | ||
{onam::kSeparator, separator}, | ||
{onam::kHasHeader, has_header}, | ||
{onam::kError, error}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'onam' [clang-diagnostic-error]
{onam::kError, error},
^
{onam::kSeparator, separator}, | ||
{onam::kHasHeader, has_header}, | ||
{onam::kError, error}, | ||
{onam::kEqualNulls, true}}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'onam' [clang-diagnostic-error]
{onam::kEqualNulls, true}}),
^
5eaffa8
to
09e56bb
Compare
* Add python bindings and error_measure option * Fix test --------- Co-authored-by: iliya-b <[email protected]>
No description provided.