Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pfdtane nongeneralized #6

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Pfdtane nongeneralized #6

wants to merge 15 commits into from

Conversation

iliya-b
Copy link
Owner

@iliya-b iliya-b commented Jan 3, 2024

No description provided.

Iliya and others added 3 commits December 8, 2023 11:32
Add TANE-based algorithm PFDTane for mining
probabilistic functional dependencies using
per-value error measure. Add tests.
github-actions[bot]

This comment was marked as outdated.

@iliya-b iliya-b force-pushed the pfdtane-nongeneralized branch from e03af21 to 63b992f Compare January 7, 2024 10:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
src/core/algorithms/fd/tane/tane.cpp Outdated Show resolved Hide resolved
@iliya-b iliya-b changed the base branch from probatane-wip to main January 7, 2024 10:33
@iliya-b iliya-b force-pushed the pfdtane-nongeneralized branch from 4633ecb to adf6486 Compare January 7, 2024 10:34
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include "table_config.h"

namespace tests {
namespace onam = config::names;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: expected namespace name [clang-diagnostic-error]

namespace onam = config::names;
                         ^


PFDTaneParams(std::string result, double const error = 0., char const* dataset = "TestFD.csv",
char const separator = ',', bool const has_header = true)
: params({{onam::kCsvPath, test_data_dir / dataset},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'onam' [clang-diagnostic-error]

        : params({{onam::kCsvPath, test_data_dir / dataset},
                   ^

PFDTaneParams(std::string result, double const error = 0., char const* dataset = "TestFD.csv",
char const separator = ',', bool const has_header = true)
: params({{onam::kCsvPath, test_data_dir / dataset},
{onam::kSeparator, separator},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'onam' [clang-diagnostic-error]

                  {onam::kSeparator, separator},
                   ^

char const separator = ',', bool const has_header = true)
: params({{onam::kCsvPath, test_data_dir / dataset},
{onam::kSeparator, separator},
{onam::kHasHeader, has_header},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'onam' [clang-diagnostic-error]

                  {onam::kHasHeader, has_header},
                   ^

: params({{onam::kCsvPath, test_data_dir / dataset},
{onam::kSeparator, separator},
{onam::kHasHeader, has_header},
{onam::kError, error},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'onam' [clang-diagnostic-error]

                  {onam::kError, error},
                   ^

{onam::kSeparator, separator},
{onam::kHasHeader, has_header},
{onam::kError, error},
{onam::kEqualNulls, true}}),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use of undeclared identifier 'onam' [clang-diagnostic-error]

                  {onam::kEqualNulls, true}}),
                   ^

@iliya-b iliya-b force-pushed the pfdtane-nongeneralized branch from 5eaffa8 to 09e56bb Compare January 11, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant