Fixed multiple dynamic relays #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to run a relay for multiple streams, the process would fail because of two issues: The config "inPath" was improperly being set with the stream path. Yjr "inPath" should just be the edge server specified in the config. Also, the onPrePlay event handler was creating a NodeRelaySession for every single task, even when the only a single onPrePlay event was fired. This would cause NMS to always return the video data for the last entry in the task list. I fixed the onPrePlay event handler to only create a NodeRelaySession for the task associated with the onPrePlayEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run a relay for multiple streams, the process would fail because of two issues:
The config "inPath" was improperly being set with the stream path. The "inPath" should just be the edge server specified in the config.
Also, the onPrePlay event handler was creating a NodeRelaySession for every single task, even when the only a single onPrePlay event was fired. This would cause NMS to always return the video data for the last entry in the task list. I fixed the onPrePlay event handler to only create a NodeRelaySession for the task associated with the onPrePlayEvent.