Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to remux signed rtmp stream #486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

D4rkTT
Copy link

@D4rkTT D4rkTT commented Sep 26, 2021

Bug: if main stream (RTMP) protected by signed key and user validating the sign argument on "prePlay" event then user won't able to remux because remux don't pass config args to trans session
Fix: pass sign argument if available so user able to remux signed rtmp stream

Bug: if main stream (RTMP) protected by signed key and user validating the sign argument on "prePlay" event then user won't able to remux because remux don't pass config args to trans session
Fix: pass sign argument if available so user able to remux signed rtmp stream
@mattcwebster
Copy link
Contributor

Please look into this one @illuspas I've noticed too that the fission streams don't have the session.publishPlayArgs with the sign argument so there's no way to auth fission paths.

@D4rkTT
Copy link
Author

D4rkTT commented Sep 28, 2021

@mattcwebster this for trans muxer
its different for fission i will edit it too to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants