fix: allow db:schema:load to work for rails 6.0 and 6.1 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprigent
commented
Sep 27, 2024
lib/data_migrate/database_tasks.rb
Outdated
| @@ -68,28 +68,23 @@ def run_migration(migration, direction) | |||
| end | |||
| end | |||
|
|
|||
| def schema_dump_path(db_config, format = ActiveRecord.schema_format) | |||
| return ENV["DATA_SCHEMA"] if ENV["DATA_SCHEMA"] | |||
| unless Gem::Dependency.new("railties", "< 7.0").match?("railties", Gem.loaded_specs["railties"].version) | |||
There was a problem hiding this comment.
I've re-extracted this check to make it more intent that we only add these two methods for newer Rails versions that have more complex support for multiple databases. All the previous gem versions compatible with rails 6.0 specifically worked without these methods.
|
@jgmontoya would love your input on this once more. I might spend a bit more time tomorrow to validate my assumptions here with more complex rails apps. (I've just tested against the ruby and sql structure config on rails 6.0 and 6.1 but not with read-replica for example.) |
jgmontoya
approved these changes
Sep 27, 2024
lib/data_migrate/database_tasks.rb
Outdated
| @@ -68,28 +68,23 @@ def run_migration(migration, direction) | |||
| end | |||
| end | |||
|
|
|||
| def schema_dump_path(db_config, format = ActiveRecord.schema_format) | |||
| return ENV["DATA_SCHEMA"] if ENV["DATA_SCHEMA"] | |||
| unless Gem::Dependency.new("railties", "< 7.0").match?("railties", Gem.loaded_specs["railties"].version) | |||
There was a problem hiding this comment.
I'd change the unless to an if and flip the condition, I think it makes it easier to read
vprigent
force-pushed
the
fix-rails-6.x-compat
branch
from
f94afe6
to
c2d2992
Compare
vprigent
force-pushed
the
fix-rails-6.x-compat
branch
from
c2d2992
to
bdc3359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still planning to only release this for 9-1. I suspect a better fix for 6.1 that would also support multi-databases might be a bit more tricky.
For a bit of context:
schema_dump_path is introduced in rails 7 and our task relies on that to improve the support for multiple databases, however full multiple data support was only handled in subsequent gem versions, so I'm hoping this patch will solve rails 6.x issues for people still using older rails versions.