Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update biomat.md #345

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update biomat.md #345

merged 1 commit into from
Oct 17, 2024

Conversation

jiri-janacek
Copy link
Collaborator

Raw links to images from my repository were added. They work as URL in ImageJ import. I am not sure which kind of address is the best,
https://github.com/jiri-janacek/biomat/raw/8eeeaf7ac4cb9b80e7f81f791796b6c3332039d6/media/MAX_2_4cortexa1.png or
https://raw.githubusercontent.com/jiri-janacek/biomat/master/media/MAX_2_4cortexa1.png or some else?

Raw links to images from my repository were added. They work as URL in ImageJ import.
I am not sure which kind of address is the best,
https://github.com/jiri-janacek/biomat/raw/8eeeaf7ac4cb9b80e7f81f791796b6c3332039d6/media/MAX_2_4cortexa1.png
or
https://raw.githubusercontent.com/jiri-janacek/biomat/master/media/MAX_2_4cortexa1.png
or some else?
@ctrueden
Copy link
Member

@jiri-janacek I would favor links like https://raw.githubusercontent.com/jiri-janacek/biomat/8eeeaf7ac4cb9b80e7f81f791796b6c3332039d6/media/MAX_2_4cortexa1.png, because that's what the github.com/.../raw/... links redirect to. Using .../master/... is a two-edged sword: you get automatic updates of the images in your documentation when they change in the repository, but you also get broken images if you move or remove the images. I would suggest to go with whatever you think will be more maintainable for you overall.

@ctrueden ctrueden merged commit 23fa7f8 into imagej:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants