Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow-override-url #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Feat/allow-override-url #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6fdedb
feat: allow GITHUB_RAW_URL to override post install url
Aghassi Sep 23, 2021
e2eb034
remove extra imagemin/mozjpeg
Aghassi Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ const path = require('path');
const BinWrapper = require('bin-wrapper');
const pkg = require('../package.json');

const url = `https://raw.githubusercontent.com/imagemin/mozjpeg-bin/v${pkg.version}/vendor/`;
const GITHUB_RAW_URL = process.env.GITHUB_RAW_URL ? process.env.GITHUB_RAW_URL : 'https://raw.githubusercontent.com'
const url = `${GITHUB_RAW_URL}/imagemin/mozjpeg-bin/v${pkg.version}/vendor/`;

module.exports = new BinWrapper()
.src(`${url}macos/cjpeg`, 'darwin')
Expand Down
5 changes: 5 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ You probably want [`imagemin-mozjpeg`](https://github.com/imagemin/imagemin-mozj
$ npm install mozjpeg
```

This package attempts to download a prebuilt binary on post install.
This attempts to reach out to `raw.githubusercontent.com`. If you would rather pull this from an
internal proxy, you can set `GITHUB_RAW_URL` on your environment to overwrite the url to your
internal proxy.


## Usage

Expand Down