Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak #12

Closed
wants to merge 1 commit into from
Closed

Fix memory leak #12

wants to merge 1 commit into from

Conversation

rickycao-qy
Copy link

Decrease ref manually to PyObject to avoid memory leak.

@rickycao-qy rickycao-qy added the bug Something isn't working label Oct 27, 2021
@rickycao-qy rickycao-qy requested a review from FeelyChau October 27, 2021 09:50
@yiwiz-sai
Copy link

thanks @rickycao-qy, Just want to know if this commit will fix #10

@FeelyChau FeelyChau mentioned this pull request Nov 4, 2021
Open
@rickycao-qy
Copy link
Author

thanks @rickycao-qy, Just want to know if this commit will fix #10

Yes，After the unit tests are fixed

@mattseddon mattseddon mentioned this pull request Nov 23, 2021
Closed
@rickycao-qy
Copy link
Author

Following PR #15 , This one will be closd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeelyChau FeelyChau Awaiting requested review from FeelyChau

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycao-qy @yiwiz-sai