Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont stringify values that are already strings #230

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: dont stringify values that are already strings #230

merged 2 commits into from
Aug 29, 2024
+724 −640

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Aug 26, 2024 •
edited
Loading

Description

  • Ensures that we don't stringify values that are already strings when storing the asset data
  • Catches fetch errors when fm=json is not supported

Checklist

  • Read the contributing guidelines.
  • Each commit follows the Conventional Commit spec format.
  • Update the readme (if applicable).
  • Update or add any necessary API documentation (if applicable)
  • All existing unit tests are still passing (if applicable).

@luqven luqven self-assigned this Aug 26, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contentful ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 11:50pm
contentful-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 11:50pm

@luqven luqven force-pushed the l/fix-double-string-encoding branch from 15d682d to 75be71c Compare August 26, 2024 23:48
@luqven luqven marked this pull request as ready for review August 26, 2024 23:52
@luqven luqven requested a review from a team as a code owner August 26, 2024 23:52
mattlaguardia
mattlaguardia approved these changes Aug 28, 2024
View reviewed changes
package.json Show resolved Hide resolved
@luqven luqven merged commit d2f76c5 into main Aug 29, 2024
5 checks passed
@luqven luqven deleted the l/fix-double-string-encoding branch August 29, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlaguardia mattlaguardia mattlaguardia approved these changes

@marco-salcedo marco-salcedo Awaiting requested review from marco-salcedo

Assignees

@luqven luqven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luqven @mattlaguardia