Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX tags and link to specific version #48

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add SPDX tags and link to specific version #48

merged 1 commit into from
Apr 22, 2024

Conversation

marbre
Copy link
Contributor

@marbre marbre commented Apr 22, 2024

No description provided.

@marbre marbre requested review from ptrdtznr and maxhoerstr April 22, 2024 07:15
@marbre
Copy link
Contributor Author

marbre commented Apr 22, 2024

@swltr as discussed offline.

Copy link
Collaborator

@maxhoerstr maxhoerstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if it's possible to assign two licenses to a single file? Also, could you explain why we use CC-BY-3.0 instead of 4.0? If I've understood correctly, the Apache-2.0 is the license from the Google styleguide, and the CC-BY-3.0 is for our changes.

@marbre
Copy link
Contributor Author

marbre commented Apr 22, 2024

I was wondering if it's possible to assign two licenses to a single file? Also, could you explain why we use CC-BY-3.0 instead of 4.0? If I've understood correctly, the Apache-2.0 is the license from the Google styleguide, and the CC-BY-3.0 is for our changes.

You can have the legal obligation to comply with two licenses and that's what the conjunctive "AND" operator is intended for.

Furthermore, we don't decide which licenses we need to comply with. CC-BY-3.0 is mentioned in the Google repo, see google/styleguide#637.

@maxhoerstr
Copy link
Collaborator

I was wondering if it's possible to assign two licenses to a single file? Also, could you explain why we use CC-BY-3.0 instead of 4.0? If I've understood correctly, the Apache-2.0 is the license from the Google styleguide, and the CC-BY-3.0 is for our changes.

You can have the legal obligation to comply with two licenses and that's what the conjunctive "AND" operator is intended for.

Furthermore, we don't decide which licenses we need to comply with. CC-BY-3.0 is mentioned in the Google repo, see google/styleguide#637.

Alright, then everything is looking fine to me :)

@maxhoerstr maxhoerstr merged commit ed15919 into main Apr 22, 2024
3 checks passed
@marbre marbre deleted the pylintrc branch April 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants