Skip to content

Commit

Permalink
fix: change redundant prop naming
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-basten committed Jun 15, 2024
1 parent c93a7aa commit c44ea24
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 19 deletions.
2 changes: 1 addition & 1 deletion web/src/lib/components/album-page/share-info-modal.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
{/if}
</div>
{#if isOwned}
<ButtonContextMenu icon={mdiDotsVertical} buttonSize="20" title={$t('options')}>
<ButtonContextMenu icon={mdiDotsVertical} size="20" title={$t('options')}>
{#if role === AlbumUserRole.Viewer}
<MenuOption on:click={() => handleSetReadonly(user, AlbumUserRole.Editor)} text={$t('allow_edits')} />
{:else}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,7 @@
on:delete={() => dispatch('delete')}
on:permanentlyDelete={() => dispatch('permanentlyDelete')}
/>
<ButtonContextMenu
direction="left"
align="top-right"
buttonColor="opaque"
title={$t('more')}
icon={mdiDotsVertical}
>
<ButtonContextMenu direction="left" align="top-right" color="opaque" title={$t('more')} icon={mdiDotsVertical}>
{#if showSlideshow}
<MenuOption icon={mdiPresentationPlay} on:click={() => onMenuClick('playSlideShow')} text={$t('slideshow')} />
{/if}
Expand Down
6 changes: 3 additions & 3 deletions web/src/lib/components/faces-page/people-card.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@
<div class="absolute top-2 right-2">
<ButtonContextMenu
buttonClass="icon-white-drop-shadow focus:opacity-100 {showVerticalDots ? 'opacity-100' : 'opacity-0'}"
buttonColor="opaque"
buttonPadding="2"
buttonSize="20"
color="opaque"
padding="2"
size="20"
icon={mdiDotsVertical}
title={$t('show_person_options')}
usePortal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
* The direction in which the context menu should open.
*/
export let direction: 'left' | 'right' = 'right';
export let buttonColor: Color = 'transparent';
export let buttonSize: string | undefined = undefined;
export let buttonPadding: string | undefined = undefined;
export let color: Color = 'transparent';
export let size: string | undefined = undefined;
export let padding: string | undefined = undefined;
/**
* Additional classes to apply to the button.
*/
Expand Down Expand Up @@ -93,17 +93,17 @@
bind:this={buttonContainer}
>
<CircleIconButton
{color}
{icon}
{padding}
{size}
{title}
ariaControls={menuId}
ariaExpanded={showContextMenu}
ariaHasPopup={true}
class={buttonClass}
color={buttonColor}
id={buttonId}
on:click={handleClick}
padding={buttonPadding}
size={buttonSize}
/>
</div>
{#if usePortal}
Expand Down
4 changes: 2 additions & 2 deletions web/src/routes/admin/library-management/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@
<td class=" text-ellipsis px-4 text-sm">
<ButtonContextMenu
align="middle"
buttonColor="primary"
buttonSize="16"
color="primary"
size="16"
icon={mdiDotsVertical}
title={$t('library_options')}
usePortal
Expand Down

0 comments on commit c44ea24

Please sign in to comment.