chore: media service unit tests #13382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danieldietzler
commented
Oct 11, 2024
danieldietzler
commented
etnoy
approved these changes
Oct 11, 2024
mertalev
approved these changes
Oct 11, 2024
| @@ -797,6 +873,21 @@ describe(MediaService.name, () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should transcode when max bitrate is not a number', async () => { | |||
| mediaMock.probe.mockResolvedValue(probeStub.videoStream40Mbps); | |||
| systemMock.get.mockResolvedValue({ ffmpeg: { transcode: TranscodePolicy.BITRATE, maxBitrate: 'foo' } }); | |||
There was a problem hiding this comment.
This should probably be a config validation error.
There was a problem hiding this comment.
Agreed, but then https://github.com/immich-app/immich/blob/main/server/src/services/media.service.ts#L465-L467 wouldn't be necessary correct?
There was a problem hiding this comment.
Yeah, that would be redundant at that point
jrasm91
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.