coremark: fix error when it was built in the second run #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there is an error building packages, and re-run with `make -j1 V=s`, the coremark package will report error `mkdir: cannot create directory '.../coremark-d5fad6bd094899101a4e5fd53af7298160ced6ab/XXX': File exists` so, add a check to see if that dir is already there; also add a '/' to the destination folder of the `cp` command fixes immortalwrt#1380
1715173329
reviewed
Dec 3, 2024
| @@ -69,8 +69,8 @@ endif | |||
|
|
|||
| define Build/Compile | |||
| $(SED) 's|EXE = .exe|EXE =|' $(PKG_BUILD_DIR)/posix/core_portme.mak | |||
| mkdir $(PKG_BUILD_DIR)/$(ARCH) | |||
| $(CP) -r $(PKG_BUILD_DIR)/linux/* $(PKG_BUILD_DIR)/$(ARCH) | |||
| [ -d "$(PKG_BUILD_DIR)/$(ARCH)" ] || mkdir $(PKG_BUILD_DIR)/$(ARCH) | |||
There was a problem hiding this comment.
I would say these operations should be done in Build/Configure stage, so the detection can be removed I guess.
1715173329
reviewed
Dec 3, 2024
| mkdir $(PKG_BUILD_DIR)/$(ARCH) | ||
| $(CP) -r $(PKG_BUILD_DIR)/linux/* $(PKG_BUILD_DIR)/$(ARCH) | ||
| [ -d "$(PKG_BUILD_DIR)/$(ARCH)" ] || mkdir $(PKG_BUILD_DIR)/$(ARCH) | ||
| $(CP) -r $(PKG_BUILD_DIR)/linux/* $(PKG_BUILD_DIR)/$(ARCH)/ |
There was a problem hiding this comment.
-r is included by $(CP) already, can be removed.
|
This PR should be sent to upstream. |
Thanks, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there is an error building packages, and re-run with
make -j1 V=s, the coremark package will report errormkdir: cannot create directory '.../coremark-d5fad6bd094899101a4e5fd53af7298160ced6ab/XXX': File existsso, add a check to see if that dir is already there;
also add a '/' to the destination folder of the
cpcommandfixes #1380