geoview: Add package #1406
Merged
geoview: Add package #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakuraFallingMad
commented
Dec 1, 2024
1715173329
requested changes
Dec 1, 2024
|
please rebase your PR and get rid of merge commit. |
SakuraFallingMad
force-pushed
the
pr_geoview
branch
4 times, most recently
from
ed69a9c to
502d71d
Compare
Signed-off-by: SakuraFallingMad <[email protected]>
SakuraFallingMad
force-pushed
the
pr_geoview
branch
from
502d71d to
1e177f3
Compare
1715173329
reviewed
Dec 1, 2024
net/geoview/Makefile
Outdated
| define Package/geoview/install | ||
| $(call GoPackage/Package/Install/Bin,$(PKG_INSTALL_DIR)) | ||
| $(INSTALL_DIR) $(1)/usr/bin | ||
| $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/geoview $(1)/usr/bin/ |
There was a problem hiding this comment.
Does this package generates any other binaries? If not you can simply remove the whole install recipe.
SakuraFallingMad
force-pushed
the
pr_geoview
branch
from
1dd6a0a to
24d215a
Compare
1715173329
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Passwall new feature, try add package to handle geo* files in Passwall.
Signed-off-by: SakuraFallingMad [email protected]