Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 updates/refactoring #145

Closed
wants to merge 4 commits into from
Closed

OAuth2 updates/refactoring #145

wants to merge 4 commits into from

Conversation

VSydor
Copy link
Contributor

@VSydor VSydor commented Jul 5, 2023

No description provided.

@VSydor VSydor requested a review from brmeyer July 5, 2023 22:35
@VSydor VSydor self-assigned this Jul 5, 2023
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch 4 times, most recently from 88d630f to 438581a Compare July 7, 2023 20:22
@VSydor VSydor changed the title Generic OAuth 2 util (In Progress) Generic OAuth 2 util Jul 7, 2023
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch 7 times, most recently from 310f071 to 67298e8 Compare July 8, 2023 08:13
@VSydor VSydor changed the title Generic OAuth 2 util OAuth2 generic util Jul 8, 2023
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch 4 times, most recently from 4aa0ebc to aad1769 Compare July 8, 2023 08:43
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch 2 times, most recently from 56d9858 to 0759183 Compare July 18, 2023 14:09
brmeyer
brmeyer requested changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@brmeyer brmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but most importantly: concerned about a possible security gap

src/main/java/com/impactupgrade/nucleus/util/OAuth2Util.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/MinistryByTextClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/util/OAuth2Util.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/MinistryByTextClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/MinistryByTextClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/RaiselyClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/SpokeClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/VirtuousClient.java Outdated Show resolved Hide resolved
src/main/java/com/impactupgrade/nucleus/client/VirtuousClient.java Outdated Show resolved Hide resolved
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch 6 times, most recently from 118771c to 5037ce8 Compare August 1, 2023 13:26
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch from 5037ce8 to 666da3c Compare August 1, 2023 13:30
@VSydor VSydor changed the title OAuth2 generic util OAuth2 updates/refactoring Aug 1, 2023
@VSydor VSydor requested a review from brmeyer August 1, 2023 14:59
@VSydor VSydor force-pushed the feature/oauth2-generic-util branch from 666da3c to 7ee0a49 Compare August 2, 2023 10:24
@VSydor VSydor closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brmeyer brmeyer Awaiting requested review from brmeyer

Assignees

@VSydor VSydor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VSydor @brmeyer