filtering out inactive tags based on configuration #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSydor
force-pushed
the
feature/mailchimp-filtering-inactive-tags
branch
2 times, most recently
from
6906f1e
to
33e1b1a
Compare
brmeyer
reviewed
Jul 13, 2023
| @@ -269,9 +269,15 @@ public static class EmailList implements Serializable { | |||
| public String crmLeadFilter = ""; | |||
| } | |||
|
|
|||
| public static class ContactTagFilters implements Serializable { | |||
There was a problem hiding this comment.
Should we combine tags and tagPrefixes into one field that allows either an explicit name or a wildcard? Then simply use .contains() in the check?
| public static class EmailPlatform extends Platform { | ||
| public List<EmailList> lists = new ArrayList<>(); | ||
| public EmailTagFilters tagFilters = new EmailTagFilters(); | ||
| public ContactTagFilters contactTagFilters = new ContactTagFilters(); |
There was a problem hiding this comment.
If we do the above, this could just be the Set and not another object
brmeyer
force-pushed
the
feature/mailchimp-filtering-inactive-tags
branch
from
bef2237
to
62dc24d
Compare
|
@brmeyer sorry for the late reply and thanks for the updates/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.