Raisely Enrichment Service Updates #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brmeyer
reviewed
Jul 26, 2023
src/main/java/com/impactupgrade/nucleus/service/segment/RaiselyEnrichmentService.java
Outdated
Show resolved
Hide resolved
| @@ -43,27 +43,28 @@ public void enrich(CrmDonation crmDonation) throws Exception { | |||
| String donationId = parseDonationId(crmDonation.description); | |||
| RaiselyClient.Donation raiselyDonation = raiselyClient.getDonation(donationId); | |||
|
|
|||
| if (raiselyDonation == null || raiselyDonation.items == null || raiselyDonation.items.size() <= 1) { | |||
| if (raiselyDonation == null || raiselyDonation.items == null) { | |||
There was a problem hiding this comment.
Should we check if both are empty too?
There was a problem hiding this comment.
Added a check for items being empty, raiselyClient.getDonation() already includes checks for empty responses. Is it safe to assume that if it gets here it has content?
|
Rebasing this so it doesn't have some of my new commits in it |
…e of each item if multiple types
brmeyer
force-pushed
the
raisely_enrichment_service_update
branch
from
57bd83f
to
3e79c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.