18623: Organisations not integrating to Xero #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review comments
brmeyer
commented
Jul 8, 2024
| crmContact.mailingAddress = crmAccount.billingAddress; | ||
| crmContact.crmRawObject = crmAccount.crmRawObject; | ||
| } | ||
| } |
There was a problem hiding this comment.
Looking at this again and wondering if we already had what they were expecting, but I'm going to email Maria and double check. The above code was creating a contact using the biz name and address already. Which I THINK is all they were asking for...
brmeyer
commented
Jul 8, 2024
| return null; | ||
| } | ||
| Contact contact = new Contact(); | ||
| contact.setName(crmAccount.name); |
There was a problem hiding this comment.
Aha, probably the root issue. For standard household accounts, shouldn't this be using the old way of doing things, primarily taking the Contact's data? We're only needing the Account name/info when it's an Organization type of account.
Let's verify that with DR first...
VSydor
approved these changes
Jul 8, 2024
|
Closing this -- got some new info from Maria that I think points to the root cause! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.