Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting dead code and unused concepts #240

Merged
merged 7 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docs/env_json.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,6 @@ https://github.com/impactupgrade/nucleus-engine/blob/master/src/main/resources/e
"secretKey": "sk_live_abc123"
},

"raisely": {
"username": "[email protected]",
"password": "abc123",
"stripeAppId": "ca_abc123"
},

"mailchimp": [
{
"secretKey": "abc123-us18",
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/com/impactupgrade/nucleus/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

package com.impactupgrade.nucleus;

import com.impactupgrade.nucleus.controller.AccountingController;
import com.impactupgrade.nucleus.controller.BackupController;
import com.impactupgrade.nucleus.controller.CommunicationController;
import com.impactupgrade.nucleus.controller.CrmController;
Expand Down Expand Up @@ -88,7 +87,6 @@ public void start() throws Exception {
apiConfig.register(new SecurityExceptionMapper());
apiConfig.register(MultiPartFeature.class);

apiConfig.register(accountingController());
apiConfig.register(backupController());
apiConfig.register(communicationController());
apiConfig.register(crmController());
Expand Down Expand Up @@ -145,7 +143,6 @@ public void registerAPIControllers(ResourceConfig apiConfig) throws Exception {}
public void registerServlets(ServletContextHandler context) throws Exception {}

// Allow orgs to override specific controllers.
protected AccountingController accountingController() { return new AccountingController(envFactory); }
protected BackupController backupController() { return new BackupController(envFactory); }
protected CommunicationController communicationController() { return new CommunicationController(envFactory); }
protected CrmController crmController() { return new CrmController(envFactory); }
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import com.ecwid.maleorang.method.v3_0.campaigns.content.GetCampaignContentMethod;
import com.ecwid.maleorang.method.v3_0.lists.members.DeleteMemberMethod;
import com.ecwid.maleorang.method.v3_0.lists.members.EditMemberMethod;
import com.ecwid.maleorang.method.v3_0.lists.members.GetMemberMethod;
import com.ecwid.maleorang.method.v3_0.lists.members.GetMembersMethod;
import com.ecwid.maleorang.method.v3_0.lists.members.MemberInfo;
import com.ecwid.maleorang.method.v3_0.lists.merge_fields.EditMergeFieldMethod;
Expand Down Expand Up @@ -79,11 +78,6 @@ public MailchimpClient(EnvironmentConfig.CommunicationPlatform mailchimpConfig,
this.env = env;
}

public MemberInfo getContactInfo(String listId, String contactEmail) throws IOException, MailchimpException {
GetMemberMethod getMemberMethod = new GetMemberMethod(listId, contactEmail);
return client.execute(getMemberMethod);
}

public void upsertContact(String listId, MemberInfo contact) throws IOException, MailchimpException {
EditMemberMethod.CreateOrUpdate upsertMemberMethod = new EditMemberMethod.CreateOrUpdate(listId, contact.email_address);
upsertMemberMethod.status_if_new = contact.status;
Expand Down
Loading
Loading