Saving sms conversations into crm task #72
Conversation
VSydor
changed the title
VSydor
changed the title
VSydor
changed the title
| @Override | ||
| public EnvironmentConfig.CRMFieldDefinitions getFieldDefinitions() { | ||
| return this.env.getConfig().salesforce.fieldDefinitions; | ||
| } | ||
|
|
||
| protected void setTaskFields(SObject task, CrmTask crmTask) { | ||
| task.setField("Id", crmTask.id); |
There was a problem hiding this comment.
There's technically a setId method. But, I vaguely remember the API might reject this if the Id is explicitly set as null, so might need a null/empty check around this
| .collect(Collectors.joining(",")); | ||
| } | ||
|
|
||
| crmTask.assignTo = "0057Q000000M8FzQAK"; // me |
| } | ||
|
|
||
| crmTask.assignTo = "0057Q000000M8FzQAK"; // me | ||
| crmTask.status = CrmTask.Status.IN_PROGRESS; |
|
|
||
| import java.util.List; | ||
|
|
||
| public class CrmActivity { |
There was a problem hiding this comment.
A little confused about the difference between CrmActivity, CrmTask, and why we need both. Lean into that for me?
There was a problem hiding this comment.
@VSydor Thoughts on this one?
There was a problem hiding this comment.
@brmeyer The idea is that crmActivity is a sub-type of crmTask that has crmActivityType (conversation or email) and conversationId fields. However, when converting to crmTask - these 2 fields just form the subject of the task (type + ":" + conversationId) so technically it's the same thing.
should I work directly with task and remove crmActivity?
There was a problem hiding this comment.
without CrmActivity will look like this:
#98
Please select the one that fits best
| @@ -172,6 +173,9 @@ default void updateContact(OpportunityEvent opportunityEvent) throws Exception { | |||
| Optional<CrmUser> getUserById(String id) throws Exception; | |||
| Optional<CrmUser> getUserByEmail(String email) throws Exception; | |||
| String insertTask(CrmTask crmTask) throws Exception; | |||
| String updateTask(CrmTask crmTask) throws Exception; | |||
| String upsertActivity(CrmActivity crmActivity) throws Exception; | |||
| Optional<CrmActivity> getActivityByTypeAndConversationId(CrmActivity.Type type, String conversationId) throws Exception; | |||
There was a problem hiding this comment.
Can we make this more generic? by type and an abstract notion of an ID? External ID?
There was a problem hiding this comment.
Renamed to external id
VSydor
force-pushed
the
feature/sms-conversation-in-crm-task
branch
from
333e589
to
b49c48a
Compare
VSydor
changed the title
VSydor
force-pushed
the
feature/sms-conversation-in-crm-task
branch
2 times, most recently
from
2c60802
to
ee7d368
Compare
…roller for manual testing
VSydor
force-pushed
the
feature/sms-conversation-in-crm-task
branch
from
ee7d368
to
907f480
Compare
|
Closing in favor of: |
…roller for manual testing