Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test certs to use rsa:2048 #601

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

davidwheeler123
Copy link
Collaborator

@davidwheeler123 davidwheeler123 commented Jun 1, 2024

As per #578 (comment) the tests are failing with an error

"/var/lib/postgresql/server.crt": ee key too small

According to this stack overflow response the solution to this is to increase key size to 2048. That's what this PR does

@davidwheeler123
Copy link
Collaborator Author

Tests have passed 😄

@davidwheeler123
Copy link
Collaborator Author

Looks like I don't have permission to merge though

@kdubb
Copy link
Member

kdubb commented Jun 1, 2024

👍

@kdubb
Copy link
Member

kdubb commented Jun 1, 2024

Permissions should be fixed

@davidwheeler123 davidwheeler123 merged commit a3e1b95 into develop Jun 2, 2024
6 checks passed
@davidwheeler123 davidwheeler123 deleted the dw/regenerate_test_certs branch June 2, 2024 22:49
@davidwheeler123
Copy link
Collaborator Author

Thanks, merged. There's another issue, couldn't deploy docs. I'll have a look when I can.

@davidwheeler123
Copy link
Collaborator Author

BTW do you like to delete the branches once PR is merged to clean up?

@davecramer
Copy link

BTW do you like to delete the branches once PR is merged to clean up?

The usual way to do this is to use your personal fork to create the PR then there is no branch to clean up

@crowmagnumb
Copy link

Hey all what's the status here. The dependency issue cropped up again with my teammate (our loophole seems to not work again). Let me know if I can help in any way to get this moving forward. Cheers.

@kdubb
Copy link
Member

kdubb commented Jun 5, 2024

@davidwheeler123 Updated the dependencies in #578, there has been no release yet.

@davidwheeler123
Copy link
Collaborator Author

The dependencies were updated nearly a year ago so I'll probably need to do it again - there's likely new CVEs cropped up since the last update.

@crowmagnumb
Copy link

Yes please, in particular io.netty is at 4.1.109.Final now. :)

@kdubb
Copy link
Member

kdubb commented Jun 5, 2024

@davidwheeler123 Thank you for pitching in... a year to get that PR 🤦‍♂️🤷‍♂️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants