Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Improve Campaign Overview page styling and structure #7666

Merged
merged 16 commits into from
Jan 13, 2025
Merged

Refactor: Improve Campaign Overview page styling and structure #7666

merged 16 commits into from
Jan 13, 2025

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 6, 2025 •
edited
Loading

Resolves GIVE-2033

Affects

This PR focuses on enhancing the visual styling and structure of the Campaign Overview page.

Styling Enhancements:

  • Improved layout and spacing for better user experience and structure.
  • Refined visual elements on the page to better align with the overall design.

Refactoring of Inline Styles:

  • Replaced inline styles in the CampaignStats, GoalProgressChart, and the DefaultFormWidget components with external stylesheets for better maintainability and consistency. I moved each component into it's own folder to help manage it.

Visuals

Campaign.Overview.mov

Testing Instructions

  • View the campaign overview page and verify there are no UI bugs.

Pre-review Checklist

  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh changed the base branch from develop to epic/campaigns January 6, 2025 04:10
@JoshuaHungDinh JoshuaHungDinh changed the title Refactor: adjust campaign overview styles Refactor: improve campaign overview page styling and structure Jan 6, 2025
@JoshuaHungDinh JoshuaHungDinh changed the title Refactor: improve campaign overview page styling and structure Refactor: Improve Campaign Overview page styling and structure Jan 6, 2025
@glaubersilva glaubersilva self-requested a review January 6, 2025 16:05
@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 6, 2025 16:08
jdghinson
jdghinson approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good!

glaubersilva
glaubersilva approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaHungDinh Looks good to me. Nice work!

rickalday
rickalday approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

@JoshuaHungDinh JoshuaHungDinh merged commit 63ed1f5 into epic/campaigns Jan 13, 2025
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the refactor/campaign-overview-GIVE-2033 branch January 13, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdghinson jdghinson jdghinson approved these changes

@glaubersilva glaubersilva glaubersilva approved these changes

@rickalday rickalday rickalday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoshuaHungDinh @rickalday @glaubersilva @jdghinson