Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove statement_descriptor from Stripe Payment Element Gateway #7673

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 10, 2025

Resolves: GIVE-1948
Related: #7259

Description

This removes the statement_descriptor from Stripe Payment Element Gateway. This is the result of a Stripe api change to the attribute for card payments. Since Payment Element is dynamic, the safest & simplest option is to remove the attribute and rely on the statement_descriptor set on the account level instead of the request.

https://support.stripe.com/questions/use-of-the-statement-descriptor-parameter-on-paymentintents-for-card-charges

Screenshot 2025-01-09 at 5 27 42 PM

Affects

Stripe payment element

Visuals

N/A

Testing Instructions

Zip: https://github.com/impress-org/givewp/actions/runs/12715146778

  • Donate using v3 forms and Stripe Payment Element w/ different payment methods including credit card and make sure everything works properly.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review January 10, 2025 17:06
@kjohnson kjohnson self-requested a review January 11, 2025 03:40
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the "credit card" payment method for Stripe Payment Elements. I don't have any others setup.

@kjohnson
Copy link
Member

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual tests.

@jonwaldstein jonwaldstein merged commit 6d52301 into develop Jan 13, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the refactor/stripe-remove-statement-descriptor branch January 13, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants